Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Access Info endpoint #35397

Merged
merged 3 commits into from Feb 23, 2024
Merged

API Access Info endpoint #35397

merged 3 commits into from Feb 23, 2024

Conversation

M0rgan01
Copy link
Contributor

@M0rgan01 M0rgan01 commented Feb 16, 2024 •
edited by jolelievre

Questions Answers
Branch? develop
Description? API Access Info endpoint
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? CI / tests UI are green
UI Tests https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/8022234004
Fixed issue or discussion? Fixes #34844
Related PRs PrestaShop/ps_apiresources#16
Sponsor company -

@M0rgan01 M0rgan01 requested a review from a team as a code owner February 16, 2024 17:04
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Feb 16, 2024
@M0rgan01 M0rgan01 added this to the 9.0.0 milestone Feb 16, 2024
@M0rgan01 M0rgan01 marked this pull request as draft February 16, 2024 17:31
@jolelievre jolelievre force-pushed the feat/34844 branch 4 times, most recently from 318d8b0 to cddf7a1 Compare February 23, 2024 09:19
@jolelievre jolelievre marked this pull request as ready for review February 23, 2024 15:22
jolelievre
jolelievre previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @M0rgan01

tleon
tleon requested changes Feb 23, 2024
View reviewed changes
src/PrestaShopBundle/ApiPlatform/Resources/ApiClient.php Outdated
operations: [
new CQRSGet(
uriTemplate: '/api-client/infos',
provider: QueryProvider::class,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nice cacth!

@ps-jarvis ps-jarvis added the Waiting for author Status: action required, waiting for author feedback label Feb 23, 2024
@jolelievre jolelievre force-pushed the feat/34844 branch 2 times, most recently from 2a74cf8 to 853298f Compare February 23, 2024 16:03
jolelievre
jolelievre previously approved these changes Feb 23, 2024
View reviewed changes
tleon
tleon previously approved these changes Feb 23, 2024
View reviewed changes
@jolelievre jolelievre removed the Waiting for author Status: action required, waiting for author feedback label Feb 23, 2024
@jolelievre jolelievre dismissed stale reviews from tleon and themself via 84d7ff7 February 23, 2024 16:17
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Feb 23, 2024
@jolelievre jolelievre removed the Waiting for QA Status: action required, waiting for test feedback label Feb 23, 2024
@jolelievre jolelievre merged commit 6087d93 into PrestaShop:develop Feb 23, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tleon tleon tleon approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

API Access Info endpoint
5 participants
@M0rgan01 @tleon @jolelievre @ps-jarvis @prestonBot