New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: The new password policy is not present in the reset password page #35410 #35418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for now, but maybe we should unify the logic, because we have basically the same code in OrderConfirmationController and GuestTrackingController. ;-)
Hi @Hlavtox, |
Hi @Hlavtox and @Codencode, Do you think it is better to unify everything in a single PR or would you prefer that we test this one and create another PR to unify the rest? Thanks for your feedback |
Hi @paulnoelcholot, We are waiting for the opinion of @Hlavtox who has more experience than me! Thank you. |
The future of the world is in your hands @Hlavtox 😄 |
@PrestaShop/qa-functional you can proceed with the tests, there's always a room for improvement later ;-) |
@paulnoelcholot @Codencode I forgot about this PR sorry guys 🤣 Lets merge this, we can improve later! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Codencode
Thank you for your PR, I tested it and it seems to works as you can see :
recording.112.webm
Link to the auto test : https://github.com/AureRita/testing_pr/actions/runs/8048090042
Because the auto test is 🟢 and the PR seems to works as expected, It's QA ✔️
Thank you
Great! Thank you @Codencode @AureRita :) |
However, this PR also requires the modification to the template that I made using the PR PrestaShop/classic-theme#140 of the classic theme. |
2. push on the link "I don't remember the password"
3. set an email to get the reset link
4. push on the reset link
5 set a new password, but weak like "casetta"
6. Password verification will not appear