Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functioanl tests - Add new test 'FO > Hummingbird > Change quantity in cart page' #35440

Merged
merged 4 commits into from Feb 22, 2024
Merged

Functioanl tests - Add new test 'FO > Hummingbird > Change quantity in cart page' #35440

merged 4 commits into from Feb 22, 2024

Conversation

nesrineabdmouleh
Copy link
Contributor

@nesrineabdmouleh nesrineabdmouleh commented Feb 21, 2024 •
edited

Questions Answers
Branch? develop
Description? Add new test 'FO > Hummingbird > Change quantity in cart page'
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
How to test? CI and nightly are 馃崗
UI Tests https://github.com/nesrineabdmouleh/testing_pr/actions/runs/7992171649
Fixed issue or discussion? no
Related PRs no
Sponsor company

@nesrineabdmouleh nesrineabdmouleh added TE Category: Tests E2E Tests labels Feb 21, 2024
@nesrineabdmouleh nesrineabdmouleh added this to the 9.0.0 milestone Feb 21, 2024
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Feb 21, 2024
@nesrineabdmouleh nesrineabdmouleh marked this pull request as ready for review February 21, 2024 15:38
@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner February 21, 2024 15:38
Progi1984
Progi1984 previously approved these changes Feb 21, 2024
View reviewed changes
@nesrineabdmouleh nesrineabdmouleh requested a review from a team as a code owner February 21, 2024 16:14
@nesrineabdmouleh nesrineabdmouleh marked this pull request as draft February 21, 2024 16:26
Progi1984
Progi1984 requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove a file

@nesrineabdmouleh nesrineabdmouleh marked this pull request as ready for review February 22, 2024 09:22
@Progi1984 Progi1984 added the QA 鉁旓笍 Status: check done, code approved label Feb 22, 2024
@Progi1984 Progi1984 merged commit 9cf1b0f into PrestaShop:develop Feb 22, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@boubkerbribri boubkerbribri boubkerbribri approved these changes

Assignees
No one assigned
Labels
develop Branch E2E Tests QA 鉁旓笍 Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nesrineabdmouleh @Progi1984 @boubkerbribri @prestonBot