Fix invoice download for non logged in customer

[Hlavtox]

Questions	Answers
Branch?	8.1.x
Description?	You can't download an invoice sometimes, if you are not logged in. This fixes it. Interesting that nobody in the huge community found it in like 13 years. :-)))
Type?	bug fix
Category?	FO
BC breaks?	no
Deprecations?	no
How to test?	See below.
UI Tests	https://github.com/kpodemski/ga.tests.ui.pr/actions/runs/8110500915
Fixed issue or discussion?	Fixes #35537
Related PRs
Sponsor company

What's wrong

• When you want to download an invoice via a standardized link https://www.domain.com/index.php?controller=pdf-invoice&id_order=XXXX&secure_key=XXXX, it doesn't work sometimes.
• The condition now says this: if there is a customer in context and it doesn't match the order customer OR the secure key doesn't match, die.
• So now if you have a perfectly legit link with secure_key, but you are logged in as different customer or start a guest checkout, the link won't work.
• So the fix is easy, die only if both of these fail:
  • If there is a customer in context and it's not the customer of the order.
  • If there isn't a secure key in the link.

How to test

• Make sure that some guest order exists in a shop and invoice is available for it.
• Go to FO, make sure you are logged out. Start a checkout as a guest (without password), no need to fill any addresses.
• Now go to guest tracking and try to track the order and try to download an invoice.
• You will get white screen and The invoice was not found..
• Same situation is when you are logged in in FO as a different customer and you have the link to the invoice in the mail for example.

[florine2623]

Oh nice, I will test it then !

[florine2623]

Hello @Hlavtox ,

Tested with/without address in Step 2.
Tested with more than 2 different guest accounts.
Tested at all stages of checkout process.

In Guest Tracking page, updated order status, the page is well updated, the link to download PDF invoice, is displayed and does not show any error.

LGTM ✅

[Hlavtox]

Thank you @florine2623! :-)