New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default catalog 8.1.x #35534
Update default catalog 8.1.x #35534
Conversation
ps-jarvis
commented
Mar 1, 2024
•
edited by Hlavtox
edited by Hlavtox
Questions | Answers |
---|---|
Branch? | 8.1.x |
Description? | Automatic update of default catalog for 8.1.x |
Type? | improvement |
Category? | IN |
BC breaks? | no |
Deprecations? | no |
How to test? | ~ |
Fixed ticket? | ~ |
UI tests | https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/8157006942 |
Related PRs | ~ |
Sponsor company | ~ |
Hello @ps-jarvis! This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community! |
Co-authored-by: Julie Varisellaz <70583503+Julievrz@users.noreply.github.com>
Co-authored-by: Julie Varisellaz <70583503+Julievrz@users.noreply.github.com>
Co-authored-by: Julie Varisellaz <70583503+Julievrz@users.noreply.github.com>
Co-authored-by: Julie Varisellaz <70583503+Julievrz@users.noreply.github.com>
Co-authored-by: Julie Varisellaz <70583503+Julievrz@users.noreply.github.com>
Is there a way to know when a string was "just moved" or maybe just highlight new wordings? |
if a string was moved it appears twice in the PR: you'll see it as added (in green), but also as removed (in red), you can do a ctrl+f to look for a piece of a wording and see if exists two times. But this is not so convenient on big PRs like this... 😓 you have to unfold everything |
@Julievrz Not really, it sucks. I tried yesterday to compare 8.1.2 to current 8.1.x to ease it up for you, but it was a mess anyway, so gave up. :( I think the easiest thing is just to check it directly in this PR in the "red section" if it was there or not. You have billion million strings there, but actually just few sentences were added. |
Ok because I unfolded and read everything that was in the green section on the right. 🥵 That's why I may have suggested changes on strings that were just moved. Let's just ignore them. Except for that one sentence that doesn't mean anything, please. 😅 |
@Julievrz Well, it's a module string, it doesn't really do anything with the core. That's one of the major issues with the translation system... I clicked "resolved" on all of the moved strings, can you confirm the two remaining? :-) |
@Julievrz Can you put Wording label? Nothing more to do on this PR. :-) |
@Julievrz about this wording: it can fixed on the module |