Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade ps_googleanalytics #35536

Merged
merged 1 commit into from Mar 1, 2024
Merged

Downgrade ps_googleanalytics #35536

merged 1 commit into from Mar 1, 2024

Conversation

matthieu-rolland
Copy link
Contributor

Questions Answers
Branch? 8.1.x
Description? Downgrade googleanalytics, this PR will also check that we don't get behat errors anymore when ps_googleanalytics is not updated to V5.x
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? CI and UI tests green
UI Tests incoming
Fixed issue or discussion? none
Related PRs none
Sponsor company PrestaShop SA

@matthieu-rolland matthieu-rolland requested a review from a team as a code owner March 1, 2024 10:50
@prestonBot prestonBot added 8.1.x Branch Bug fix Type: Bug fix labels Mar 1, 2024
@PrestaShop PrestaShop deleted a comment from prestonBot Mar 1, 2024
@matthieu-rolland matthieu-rolland changed the title remove former round fix Downgrade ps_googleanalytics Mar 1, 2024
jolelievre
jolelievre requested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's relevant to downgrade this, it only hides the fact that the module is buggued and already upgradable via the API

@kpodemski
Copy link
Contributor

kpodemski commented Mar 1, 2024 •
edited

I don't think it's relevant to downgrade this, it only hides the fact that the module is buggued and already upgradable via the API

It shows deprecations (passing null). It passed QA validation ;-) Errors related to packs should not related to the GA module. Possibly, it is a problem later in the chain when the first operation on the cart in the tests fails.

@matthieu-rolland
Copy link
Contributor Author

I don't think it's relevant to downgrade this, it only hides the fact that the module is buggued and already upgradable via the API

imho we should downgrade it as long as the module is not fixed, and when it's fixed we upgrade it again

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Mar 1, 2024
@matthieu-rolland
Copy link
Contributor Author

https://github.com/matthieu-rolland/ga.tests.ui.pr/actions/runs/8110254754

@matthieu-rolland matthieu-rolland removed the Waiting for QA Status: action required, waiting for test feedback label Mar 1, 2024
@matthieu-rolland matthieu-rolland merged commit 628ab4f into PrestaShop:8.1.x Mar 1, 2024
38 checks passed
@matthieu-rolland matthieu-rolland deleted the downgrade-googleanalytics branch March 1, 2024 12:40
@matthieu-rolland matthieu-rolland added this to the 8.1.5 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees
No one assigned
Labels
8.1.x Branch Bug fix Type: Bug fix
Projects
PR Dashboard
Archived in project
Milestone
8.1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthieu-rolland @kpodemski @jolelievre @ps-jarvis @prestonBot