Changed attribute value creation route #35865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonBot
added
Bug fix
nicosomb
force-pushed
the
change-create-value-attr-route
branch
from
0ae0d7e
to
f8dc70c
Compare
nicosomb
force-pushed
the
change-create-value-attr-route
branch
from
f8dc70c
to
2e58ab6
Compare
jolelievre
requested changes
Apr 15, 2024
src/Core/Domain/AttributeGroup/ValueObject/AttributeGroupId.php
Outdated
Show resolved
Hide resolved
src/PrestaShopBundle/Resources/config/routing/admin/sell/catalog/attribute.yml
Show resolved
Hide resolved
nicosomb
force-pushed
the
change-create-value-attr-route
branch
from
4f97c7d
to
d79a72c
Compare
nicosomb
commented
Apr 18, 2024
| @@ -27,13 +27,7 @@ _features: | |||
| prefix: /features | |||
|
|
|||
| _attributes: | |||
| resource: "attribute.yml" | |||
There was a problem hiding this comment.
As discussed with @jolelievre, we decided to merge attribute.yml and attribute_group.yml. Like that, we can handle routes with {attributeGroupId} parameter and those without it in the same file.
boherm
approved these changes
Apr 18, 2024
|
UI tests are green https://github.com/nicosomb/ga.tests.ui.pr/actions/runs/8690654054 |
jolelievre
added
the
Waiting for QA
florine2623
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Hello @nicosomb ,
LGTM ✅
Button to add a new value is well displayed on attributes listing page.
Thanks!
florine2623
added
QA ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every detail helps: versions, browser/server configuration, specific module/theme, etc. Feel free to add more information below this table.