New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves the random admin folder name generation at the end of the install process #35998
Moves the random admin folder name generation at the end of the install process #35998
Conversation
e06d3e9
to
6b71b77
Compare
25c8a75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @matthieu-rolland
26cf27a
to
442c142
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @matthieu-rolland
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR, I tested it with you and we seen that works as expected
Link to the auto test : https://github.com/matthieu-rolland/ga.tests.ui.pr/actions/runs/8830417094
Because the auto test is 🟢 and the PR seems to works as expected, It's QA ✔️
Thank you
c205667
thank you @jolelievre ! here's the latest ui test: https://github.com/matthieu-rolland/ga.tests.ui.pr/actions/runs/8850250859 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @matks
Thank you for your PR, I tested it and it seems to works, except the Print of the new name of the admin as you can see :
If this event is good for you, It'll be QA ✔️
Link to the auto test : https://github.com/matthieu-rolland/ga.tests.ui.pr/actions/runs/8850250859
Because the auto test is 🟢 and the PR seems to works as expected, It's QA ✔️
Thank you
2/ Install the release manually
3/ It should work as before.
4/ Same test with CLI install, from a release from this PR as well
Review guide:
Before this PR, in production, the admin folder name is not generated at install, it is generated when we first display the BO login page.
With this PR, the admin folder name is generated at the end of the install process
In a nutshell, this PR dos:
*The random admin folder name is generated at the beginning of the install process so that the name of the folder is available in the final install page, where the link is displayed, because this page is generated before the install process.