Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

35591 b10 migrated attribute pages bug 10 #36007

Conversation

mattgoud
Copy link
Contributor

@mattgoud mattgoud commented Apr 24, 2024

Questions Answers
Branch? develop
Description? related #35591 - fix bug 10 : Attribute group list is not by default sorted by position
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Indicate how to verify that this change works as expected.
UI Tests Please run UI tests and paste here the link to the run. Read this page to know why and how to use this tool..
Fixed issue or discussion? Fixes #36012
Related PRs If theme, autoupgrade or other module change is needed to make this change work, provide a link to related PRs here.
Sponsor company Your company or customer's name goes here (if applicable).

@mattgoud mattgoud requested a review from a team as a code owner April 24, 2024 09:19
@prestonBot
Copy link
Collaborator

Hello @mattgoud!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels Apr 24, 2024
@mattgoud mattgoud closed this Apr 25, 2024
@mattgoud mattgoud reopened this Apr 25, 2024
@mattgoud mattgoud closed this Apr 25, 2024
@mattgoud
Copy link
Contributor Author

closed in favor of #36026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix develop Branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

related #35591 - bug 10 : Attribute group list is not by default sorted by position
2 participants