Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable rows for attributes group and attributes lists #36028

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mattgoud
Copy link
Contributor

@mattgoud mattgoud commented Apr 25, 2024

Questions Answers
Branch? develop
Description? related #35591 - fix bug 9 : Can't click on the row to view the attribut value list
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Indicate how to verify that this change works as expected.
UI Tests https://github.com/florine2623/testing_pr/actions/runs/8875714123
Fixed issue or discussion? Fixes #36011
Related PRs If theme, autoupgrade or other module change is needed to make this change work, provide a link to related PRs here.
Sponsor company Your company or customer's name goes here (if applicable).

@mattgoud mattgoud requested a review from a team as a code owner April 25, 2024 09:47
@prestonBot
Copy link
Collaborator

Hello @mattgoud!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@nicosomb nicosomb added the Waiting for QA Status: action required, waiting for test feedback label Apr 29, 2024
@florine2623 florine2623 self-assigned this Apr 29, 2024
@nicosomb nicosomb removed the Waiting for QA Status: action required, waiting for test feedback label Apr 29, 2024
@nicosomb nicosomb self-requested a review April 29, 2024 13:48
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix develop Branch Waiting for QA Status: action required, waiting for test feedback
Projects
Status: To be tested
Development

Successfully merging this pull request may close these issues.

related #35591 - bug 9 : Can't click on the row to view the attribut value list
6 participants