Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed useless aliases which cause issue with MariaDB #36052

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Removed useless aliases which cause issue with MariaDB #36052

merged 1 commit into from
Apr 30, 2024

Conversation

nicosomb
Copy link
Contributor

@nicosomb nicosomb commented Apr 29, 2024 •
edited

Questions Answers
Branch? develop
Description? Aliases on table in DELETE queries aren't compatible with MariaDB
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? green tests
UI Tests https://github.com/nicosomb/ga.tests.ui.pr/actions/runs/8891200020
Fixed issue or discussion? Fixes #33157
Related PRs
Sponsor company PrestaShop SA

@nicosomb nicosomb added the WIP Status: Work In Progress label Apr 29, 2024
@prestonBot prestonBot added Bug fix Type: Bug fix BC break Type: Introduces a backwards-incompatible break labels Apr 29, 2024
@nicosomb nicosomb mentioned this pull request Apr 29, 2024
Open
2 tasks
@prestonBot prestonBot added the develop Branch label Apr 30, 2024
@PrestaShop PrestaShop deleted a comment from prestonBot Apr 30, 2024
@nicosomb nicosomb added 9.0.x Branch and removed BC break Type: Introduces a backwards-incompatible break labels Apr 30, 2024
@nicosomb nicosomb added this to the 9.0.0 milestone Apr 30, 2024
@nicosomb nicosomb marked this pull request as ready for review April 30, 2024 08:03
@nicosomb nicosomb requested a review from a team as a code owner April 30, 2024 08:03
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Apr 30, 2024
@Hlavtox
Copy link
Contributor

Hlavtox commented Apr 30, 2024

@nicosomb Given how simple the PR is, what about 8.1.x?

@nicosomb
Copy link
Contributor Author

@Hlavtox because src/Adapter/CartRule/Repository/CartRuleRepository.php doesn't exist in 8.1.x ? 😉

@Hlavtox
Copy link
Contributor

Hlavtox commented Apr 30, 2024

@nicosomb Ahaaaa, that makes sense! :D

@nicosomb nicosomb added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 30, 2024
@nicosomb
Copy link
Contributor Author

UI tests are green https://github.com/nicosomb/ga.tests.ui.pr/actions/runs/8891200020

@nicosomb nicosomb merged commit 8670a27 into PrestaShop:develop Apr 30, 2024
35 checks passed
@nicosomb nicosomb deleted the remove-useless-aliases branch April 30, 2024 09:47
@nicosomb nicosomb removed the WIP Status: Work In Progress label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokesterfr jokesterfr jokesterfr approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees
No one assigned
Labels
9.0.x Branch Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

MariaDB Incompatibility
6 participants
@nicosomb @Hlavtox @jokesterfr @matthieu-rolland @ps-jarvis @prestonBot