Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain category options #36091

Merged
merged 1 commit into from
May 4, 2024
Merged

Explain category options #36091

merged 1 commit into from
May 4, 2024

Conversation

fulldecent
Copy link
Contributor

Questions Answers
Branch? develop
Description? Explains which category to choose when making pull requests
Type? improvement
Category? PM
BC breaks? no
Deprecations? no
How to test? Read code
UI Tests none
Fixed issue or discussion? none
Related PRs all future ones :-)

@fulldecent fulldecent requested a review from a team as a code owner May 3, 2024 20:34
@prestonBot
Copy link
Collaborator

Hello @fulldecent!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels May 3, 2024
@fulldecent
Copy link
Contributor Author

Inspired by explanations from @prestonBot #36088 (comment)

@fulldecent
Copy link
Contributor Author

Also updated at PrestaShop/prestonbot#150

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label May 4, 2024
@nicosomb nicosomb added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 4, 2024
@nicosomb nicosomb added this to the 9.0.0 milestone May 4, 2024
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@nicosomb nicosomb merged commit fe8027c into PrestaShop:develop May 4, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@Hlavtox Hlavtox Hlavtox approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fulldecent @prestonBot @nicosomb @Hlavtox @ps-jarvis