Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional Tests : Support for MariaDB #36295

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Functional Tests : Support for MariaDB #36295

merged 1 commit into from
Jun 14, 2024
+173 −21

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Jun 3, 2024 •
edited
Loading

Questions Answers
Branch? develop
Description? Functional Tests : Support for MariaDB
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? CI is 🟢
UI Tests
Fixed issue or discussion? N/A
Related PRs N/A
Sponsor company @PrestaShopCorp

Linked PRs

Linked Issues

@Progi1984 Progi1984 added TE Category: Tests E2E Tests labels Jun 3, 2024
@Progi1984 Progi1984 added this to the 9.0.0 milestone Jun 3, 2024
@Progi1984 Progi1984 force-pushed the supportMariaDB branch 10 times, most recently from cfa28f7 to 3c3931a Compare June 3, 2024 15:11
jolelievre
jolelievre reviewed Jun 6, 2024
View reviewed changes
.github/workflows/sanity.yml Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@Progi1984 Progi1984 force-pushed the supportMariaDB branch 3 times, most recently from a048d7e to a807f12 Compare June 13, 2024 08:31
@Progi1984 Progi1984 marked this pull request as ready for review June 13, 2024 14:58
@Progi1984 Progi1984 requested review from a team as code owners June 13, 2024 14:58
SD1982
SD1982 previously approved these changes Jun 13, 2024
View reviewed changes
jolelievre
jolelievre reviewed Jun 13, 2024
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
boherm
boherm previously approved these changes Jun 14, 2024
View reviewed changes
@Progi1984 Progi1984 dismissed stale reviews from boherm and matthieu-rolland via a7f1dfc June 14, 2024 08:40
@Progi1984 Progi1984 force-pushed the supportMariaDB branch 4 times, most recently from 23ea091 to 216c40e Compare June 14, 2024 08:52
boherm
boherm previously approved these changes Jun 14, 2024
View reviewed changes
jolelievre
jolelievre approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Progi1984

@jolelievre jolelievre merged commit 34a3e06 into PrestaShop:develop Jun 14, 2024
46 checks passed
@Progi1984 Progi1984 deleted the supportMariaDB branch June 14, 2024 09:38
@nicosomb nicosomb mentioned this pull request Jun 14, 2024
Closed
2 tasks
@grooverdan
Copy link
Contributor

Thank you very much @Progi1984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolelievre jolelievre jolelievre approved these changes

@boherm boherm boherm approved these changes

@nicosomb nicosomb Awaiting requested review from nicosomb

@matthieu-rolland matthieu-rolland Awaiting requested review from matthieu-rolland

@SD1982 SD1982 Awaiting requested review from SD1982

Assignees
No one assigned
Labels
E2E Tests TE Category: Tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Progi1984 @grooverdan @matthieu-rolland @jolelievre @boherm @SD1982