Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing issue #36401 duplicated invalid text #36403

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fixing issue #36401 duplicated invalid text #36403

wants to merge 1 commit into from
+1 −1

Conversation

jackoske
Copy link

@jackoske jackoske commented Jun 21, 2024 •
edited by matks
Loading

Questions Answers
Branch? develop
Description? Admin.Shopparameters.Help variable already had the hardcoded text resulting in duplicate, I simply removed the hardcoded text
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? go to catalog -> catagories -> edit or new -> view meta keywords

Invalid characters: <>;=#{} is no longer duplicated
UI Tests (TO DO)Please run UI tests and paste here the link to the run. Read this page to know why and how to use this tool.
Fixed issue or discussion? Fixes #36401

@jackoske jackoske marked this pull request as ready for review June 21, 2024 19:03
@jackoske jackoske requested a review from a team as a code owner June 21, 2024 19:03
@ps-jarvis ps-jarvis added the Bug fix Type: Bug fix label Jun 21, 2024
@ps-jarvis
Copy link

Hello @jackoske!

This is your first pull request on PrestaShop repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@ps-jarvis ps-jarvis added the develop Branch label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug fix Type: Bug fix develop Branch
Projects
PR Dashboard
Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

develop - On category page, meta keywords helptext is duplicated
2 participants
@jackoske @ps-jarvis