Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] BO : Not updating OrderInvoice addresses #3883

Closed
wants to merge 1 commit into from

Conversation

djbuch
Copy link
Contributor

@djbuch djbuch commented Sep 2, 2015

The address caches should be updated when the address of an order is edited

The address caches should be updated when the address of an order is edited
@firstred
Copy link
Contributor

Hi @djbuch

Thanks for your PR and sorry for the long wait (are you still around?)

This looks like a good PR to me. Could you please rebase it, so that we can test it? Thank you!

@firstred firstred added Waiting for rebase Status: action required, waiting for rebase Waiting for PM Status: action required, waiting for product feedback labels Oct 12, 2016
@firstred
Copy link
Contributor

firstred commented Oct 12, 2016

Basically what this PR does is update the registered Address in the OrderInvoice when the Address of an order has been changed. (If I understand correctly)

@xBorderie
Copy link
Contributor

@firstred If you find this PR good to take, and since @djbuch doesn't seem responsive (who can blame him?), do you think you could pick his commits into a new PR?

@antoin-m antoin-m self-assigned this Feb 8, 2017
@antoin-m
Copy link
Contributor

antoin-m commented Feb 8, 2017

Thank you @djbuch, I cherry-picked your PR here #7498

@antoin-m antoin-m closed this Feb 8, 2017
@vincentbz
Copy link
Contributor

Hi @djbuch

I've tried to reproduce the bug before applying your fix and I can't. here is what i've done :

  • two orders (1 and 2) with an address A, validated
  • In the order 2, I modify the delivery or invoice address
  • the address is changed only for that order on the invoice and in the order display

Did I miss something ? :)
It seems to be the expected behaviour.

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for PM Status: action required, waiting for product feedback Waiting for rebase Status: action required, waiting for rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants