[-] FO : Fix #PSCSX-6751, gets the carrier available with weight attribute #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Considers the weight of products attributes. Bug fix http://forge.prestashop.com/browse/PSCSX-6751
webagil-kevin
changed the title
|
💝 Thank you for your PR and dedication. |
|
👍 |
gRoussac
added a commit
that referenced
this pull request
Sep 16, 2015
[-] FO : Fix #PSCSX-6751, gets the carrier available with weight attribute
|
Thank you for your PR and contribution. Best regards |
nsorosac
reviewed
Nov 3, 2017
| @@ -1401,7 +1407,7 @@ public static function getAvailableCarrierList(Product $product, $id_warehouse, | |||
| unset($carrier_list[$key]); | |||
| } | |||
|
|
|||
| if ($carrier->max_weight > 0 && $carrier->max_weight < $product->weight * $cart_quantity) { | |||
| if ($carrier->max_weight > 0 && ($carrier->max_weight < $product->weight * $cart_quantity OR $carrier->max_weight < $cart_weight)) { | |||
There was a problem hiding this comment.
As mentionned here : http://forge.prestashop.com/browse/PSCSX-6751?focusedCommentId=156257&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-156257
Shouldn't this condition become only "if ($carrier->max_weight > 0 && $carrier->max_weight < $cart_weight)" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considers the weight of products attributes.
Bug fix http://forge.prestashop.com/browse/PSCSX-6751