[~] BO : Remove open graph title/description #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exists on modules seo expert
xGouley
added a commit
that referenced
this pull request
Oct 28, 2015
[~] BO : Remove open graph title/description
|
I am against removing OGP tags from core and native social share module. Or is this a revert of the social sharing commit that I was so strongly against? |
|
Hi, We removed it because it has no sense to leave it in the core while it's not something essential for most of the users and there are many modules doing it. |
|
@vincentbz When I review the pull, it's just taking out those custom BO features to change the title and description. I don't see any OGP tag work in the pull. Did I miss something? |
|
We don't modify at all the native module. We planned to add something that would be a duplicate of SEO expert module or other module. And we removed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, this features already exists on seo expert module