Calculate carrier price on the real order price (develop)

[axometeam]

Calculate the carrier price with the REAL price customer is gonna pay, so have to use the BOTH_WITHOUT_SHIPPING const.

By now the Discount is not use in the calculation.
For exemple if you have a specific carrier price range for order > 50€ => free shipping. If the customer buy an 60€ item and use a -20% discount, customer gonna pay 48€ AND have the free shipping.

I think it's not the expected functionment

[xBorderie]

Thank you for this new PR @axometeam!

Note: this is a recreation of @MrManchot's #2324 PR for the developbranch. See that older ticket for the discussion.

[brrrrrrrt]

is there a reason that this is still not fixed in current stable 1.6.1.5?

[MrManchot]

I think PrestaShop totally adbandon 1.6 😞
Le 5 juin 2016 7:43 PM, "Robert Breithuber" notifications@github.com a
écrit :

is there a reason that this is still not fixed in current stable 1.6.1.5?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[xBorderie]

Rest assured that v1.6 is nowhere close to be abandoned: as you can see here, the 1.6.1.6 milestone is almost ready to ship, and we are already preparing for the 1.6.1.7 milestone.

About this PR: it was initially made by @MrManchot in #2324, based on the 1.6 branch. Sadly, that branch was abandoned in July 2015 when we switched to SemVer-like versioning, and the work on PS 1.6 is now done in branch 1.6.1.x. @MrManchot's team, @axometeam, therefore remade the initial PR for PS 1.7 (develop branch) -- but did not remake it for the 1.6.1.x, which explains why this has not landed in v1.6 yet. Fee free to contribute this PR on the 1.6.1.x branch!

[xBorderie]

Thank you @maximebiloe for making #5698, a port of the initial PR for the 1.6.1.x branch \o/

[therampagerado]

Can we copy this in 1.6.1.x for 1.8???

It's very nasty bug that I discovered few days ago and this pull request seems to fix it.

*I tried to make a pull request (as you may see) but I failed miserably... is there some GUI based client that can do everything?

[maximebiloe]

Hello @axometeam,

Sorry for the very late reply.
This constant has been deprecated in 1.7. What do you think of using Cart::BOTH_WITHOUT_SHIPPING instead?

Regards

[axometeam]

Hello @maximebiloe

I'm not sure to understand, the commit already use the Cart::BOTH_WITHOUT_SHIPPING constant

Regards

[maximebiloe]

Oh sorry, my bad ^^

It seems ok to me then. But when I run the tests in local it's still red.
Would mind to rebase your PR, please?

Regards

[antoin-m]

Hey @axometeam, thank you for your contribution.

I cherry-picked your commit here so you won't have to rebase.