Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[-] FO : Logo should not be larger than box, fit logo within box while keeping proportions #4462

Conversation

dkarvounaris
Copy link
Contributor

Fixes also a </div> too much

@gskema
Copy link
Contributor

gskema commented Nov 13, 2015

Hard to see what you've changed :(

@maximebiloe
Copy link
Contributor

Hello,

@dkarvounaris, you should put your style into the css file maintenance.css, the inline style is not recommended.

@gskema, you can add ?w=1 into the URL to remove the all the differences about spaces.

Regards

@dkarvounaris
Copy link
Contributor Author

@maximebiloe It's updated!

@vTerenti
Copy link
Contributor

QA OK

@vTerenti vTerenti added the QA ✔️ Status: check done, code approved label Feb 24, 2016
@Shudrum
Copy link
Contributor

Shudrum commented Apr 6, 2016

Sorry, but the CSS files should not be edited directly. Please modify the SASS file and recreate a PR with the SASS & compiled CSS :)

P.S.: Are you sure that width AND height keep the aspect ratio?

Thank you 👍

@Shudrum Shudrum closed this Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants