Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

// CORE : Remove broken links to the SQL table modules_perfs #5326

Merged

Conversation

Quetzacoalt91
Copy link
Member

Description

This PR fixes the SQL Exception when the constant _PS_DEBUG_PROFILING_ is set as true.

The SQL table modules_perfs has been recently deleted. But some SQL insertion and selection were not removed. This PR cleans the profiling results from modules performance data.

Steps to Test this Fix

  1. Change the value to true of the constant _PS_DEBUG_PROFILING_ in the file config/defines.inc.php
  2. The shop should crash
  3. Apply the pull-request changes
  4. Wow, now it works again !

Forge Ticket (optional)

Not related to a Jira issue.

@Quetzacoalt91 Quetzacoalt91 added the Bug Type: Bug label Apr 7, 2016
@firstred
Copy link
Contributor

firstred commented Apr 7, 2016

So that's why I couldn't enable profiling.
I can confirm that this solves the problem. Thanks a lot!

@tchauviere tchauviere added Code reviewed Waiting for QA Status: action required, waiting for test feedback labels Apr 8, 2016
@tchauviere tchauviere merged commit a1160ba into PrestaShop:develop Apr 8, 2016
@Quetzacoalt91 Quetzacoalt91 deleted the remove-modules-perf-table branch April 8, 2016 15:44
@Shine-neko
Copy link
Contributor

:( I had started working on
4628bc6

Shudrum pushed a commit that referenced this pull request Apr 14, 2016
// CORE : Remove broken links to the SQL table modules_perfs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug Waiting for QA Status: action required, waiting for test feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants