[-] CORE : Bugfix blockcart.tpl double negation

[Nobodaddy]

Because of a double negation /themes/default-bootstrap/modules/blockcart/blockcart.tpl the ajax cart always displayed 'free shipping' instead of 'To be determined'. This affects all 1.6.1.x releases.

Whereas the if-clause in line 287 makes no sense when the customer is already logged in, because the cart will always display 'free shipping' when there is a delivery address - no matter if a carrier was selected at that time or not.

[vincentbz]

Hi @Nobodaddy

Thanks for this PR.
There is something wrong in the current behavior, you're right.
If we fix here, we should also fix in the shopping cart summary before chosing the address, see image below. Otherwise there could be a bigger misunderstanding

[Nobodaddy]

@vincentbz
Exactly, I totally agree.
I guess you need to verify these 2 conditions

• if the customer has already chosen a carrier and
• if the cart value exceeds a certain limit for free shipping.

And afterwards the third one - delivery address. But as the shipping costs normally are calculated per coverage of the carrier chosen, the delivery address may be even added as last action before the customer places his order.
Even more comfortable would be to check before, if the shop has only one carrier. In this case the shipping costs would be displayed from the beginning on until the limit for free shipping was reached.

[aleeks]

Hello @Nobodaddy
I'm closing this PR because it's apparently incomplete.
To merge this solution, it must be complete because it is a branch of fix.

Regards