Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHPDocs to Attribute class #5992

Merged
merged 1 commit into from Aug 24, 2016
Merged

Added PHPDocs to Attribute class #5992

merged 1 commit into from Aug 24, 2016

Conversation

firstred
Copy link
Contributor

Questions Answers
Branch? develop
Description? Upgrading the PHPDoc comments of this class, using the latest PS standards and also applying the PS standards to some of the code. Also getting the Franglais out of the comments, getting rid of things the Symfony code sniffer nags about, etc. It might have some additional todo tags, depending on whether the code was comprehensible or not.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A

*
* @param array $arr Array with Product ID and quantity
*
* @return bool Whether the quantity of the product in the given array could be updated successfully
*/
public static function updateQtyProduct(&$arr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this method can by completely removed as it is deprecated for a while

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @Shudrum :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it! Thank you!

@firstred? Or someone?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed :)

@mickaelandrieu mickaelandrieu changed the title CO: Document Attribute class Added PHPDocs to Attribute class Aug 24, 2016
@mickaelandrieu mickaelandrieu merged commit 99b4ba6 into PrestaShop:develop Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants