Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix id_carrier check on module #6012

Merged
merged 1 commit into from Aug 16, 2016
Merged

Fix id_carrier check on module #6012

merged 1 commit into from Aug 16, 2016

Conversation

firstred
Copy link
Contributor

@firstred firstred commented Aug 14, 2016

Questions Answers
Branch? develop
Description? Should use property_exists instead of array_key_exists. The current "hack" somehow still works, but we aren't checking an array, but rather an object instead. In order to future-proof the code we should use the right method. I even consider it a bug, because by the grace of PHP it still works, but this could end one day 馃槈
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? Generate a CarrierModule @ https://validator.prestashop.com and check if the module still works

@Shudrum Shudrum changed the title CO: fix id_carrier check on module Fix id_carrier check on module Aug 16, 2016
@Shudrum Shudrum merged commit 48d878c into PrestaShop:develop Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants