Moving the call to the function renderwidget

[frederic-benoist]

Questions	Answers
Branch?	develop
Description?	Simple move for futur override (necessary for profiling)
Type?	improvement
Category?	CO
BC breaks?	no
Deprecations?	no
Fixed ticket?	N/A
How to test?	not for now

[Shudrum]

Hi!

What do you wan't to do with this?

I mean: statics are BAD, and we do not wan't to add some statics methods anymore.
If you have a REALLY good reason that cannot be resolved in a better way, why not.

[frederic-benoist]

Without this change, how to add profiling modules on PrestaShop 1.7?
Some examples :

• ps_banner use renderWidget on displayHome
• ps_contactinfo use renderWidget on displayNav1 and displayFooter
• ps_linklist use renderWidget on displayFooter

This solution allows the creation of an override function as with the hook::coreCallHook()

[Shudrum]

So the main problem is that we have removed some hooks?

[frederic-benoist]

No.
With the new renderWidget interface the old profiling tools can't works (hook::coreCallHook() is not used),

With this change, it's possible to override the module call (the new function hook::coreRenderWidget) and add Profiling.

[Shudrum]

Ok, I understand the problem and you cannot do something better and you have just followed the other static method just bellow.

It is ok for me :)

But before merging : can you remove the merge commit ? Your pull request should only contain your commit.

Thank you!

[frederic-benoist]

remove merge commit done.

Thx

[Shudrum]

Thank you!