Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO: Fix getImageLink for watermark module #6199

Closed
wants to merge 1 commit into from

Conversation

Shagshag
Copy link
Contributor

@Shagshag Shagshag commented Sep 7, 2016

Questions Answers
Branch? 1.6.1.x
Description? If watermark module is enable Link::getImageLink doesn't return a valid link for original picture.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Enable watermark, Link::getImageLink('my-picture', 12) return http://example.com/12--EZEJSDSD/my-picture.jpg instead of http://example.com/12/my-picture.jpg

@mickaelandrieu mickaelandrieu changed the title CO: Can't get original picture link if watermark is enable Can't get original picture link if watermark is enable Sep 7, 2016
@Shagshag Shagshag changed the title Can't get original picture link if watermark is enable CO: Fix getImageLink for watermark module Sep 7, 2016
@Shagshag
Copy link
Contributor Author

Shagshag commented Sep 7, 2016

As this PR was created on the GitHub interface, I will close it and recreate it with an other name.

About title convention, @mickaelandrieu rename it and remove the 'CO: ...'
so CO: or not CO: ?

@Shagshag Shagshag closed this Sep 7, 2016
@Shagshag
Copy link
Contributor Author

Shagshag commented Sep 7, 2016

Done #6206

@xBorderie
Copy link
Contributor

Thanks!

About title convention, @mickaelandrieu rename it and remove the 'CO: ...'
so CO: or not CO: ?

"CO:" is only used by our changelog system, which parses the commit names.
The PR title, on the other hand, is purely for human eyes, so no need for "CO" (or others) there.
Eeasy, right? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants