Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed registration process type option #6203

Merged
merged 1 commit into from Sep 8, 2016
Merged

Removed registration process type option #6203

merged 1 commit into from Sep 8, 2016

Conversation

mickaelandrieu
Copy link
Contributor

Questions Answers
Branch? develop
Description? This option is not useful anymore.
Type? improvement
Category? BO
BC breaks? yes
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1047
How to test? You can't see the option displayed anymore, the code wasn't used at this point so the front office was already aware of this deprecation.

Important guidelines

@vincentbz
Copy link
Contributor

Tested and ok, thanks !

@prestonBot prestonBot added the QA ✔️ Status: check done, code approved label Sep 7, 2016
maximebiloe
maximebiloe reviewed Sep 8, 2016
View reviewed changes
controllers/admin/AdminCustomerPreferencesController.php
@@ -27,7 +27,8 @@
/**
* @property Configuration $object
*/
class AdminCustomerPreferencesControllerCore extends AdminController
class
AdminCustomerPreferencesControllerCore extends AdminController
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the new line? 😜

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thank you

@prestonBot prestonBot added PM ✔️ Status: check done, behavior approved QA ✔️ Status: check done, code approved and removed QA ✔️ Status: check done, code approved PM ✔️ Status: check done, behavior approved labels Sep 8, 2016
@maximebiloe maximebiloe merged commit 683da88 into PrestaShop:develop Sep 8, 2016
@maximebiloe maximebiloe deleted the boom-1047-remove-registration-process-type-option branch September 8, 2016 13:48
@maximebiloe
Copy link
Contributor

Thank you!

@mickaelandrieu mickaelandrieu added the PM ✔️ Status: check done, behavior approved label Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PM ✔️ Status: check done, behavior approved QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mickaelandrieu @vincentbz @maximebiloe @prestonBot