Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Attachment class to ps standards #6217

Merged
merged 1 commit into from Sep 8, 2016
Merged

Update Attachment class to ps standards #6217

merged 1 commit into from Sep 8, 2016

Conversation

firstred
Copy link
Contributor

@firstred firstred commented Sep 8, 2016

Questions Answers
Branch? develop
Description? Upgrading the PHPDoc comments of this class, using the latest PS standards and also applying the PS standards to some of the code. Also getting the Franglais out of the comments, getting rid of things the Symfony code sniffer nags about, etc. It might have some additional todo tags, depending on whether the code was comprehensible or not.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A

Warning: this PR also has a code cleanup. Please check this first before merging!

@firstred firstred changed the title CO: update Attachment class to ps standards Update Attachment class to ps standards Sep 8, 2016
@mickaelandrieu mickaelandrieu merged commit 77b4898 into PrestaShop:develop Sep 8, 2016
@mickaelandrieu
Copy link
Contributor

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants