Add customization message #6908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fatmaBouchekoua
commented
Nov 4, 2016
fatmaBouchekoua
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Add customization message |
| Type? | improvement |
| Category? | FO |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | http://forge.prestashop.com/browse/BOOM-992 |
| How to test? | Go to the product details page and add customization. |
maximebiloe
reviewed
Feb 1, 2017
| <textarea placeholder="{l s='Your message here' d='Shop.Forms.Help'}" class="product-message" maxlength="250" {if $field.required} required {/if} name="{$field.input_name}"></textarea> | ||
| <small class="pull-xs-right">{l s='250 char. max' d='Shop.Forms.Help'}</small> | ||
| {if $field.text !== ''} | ||
| <br><br> |
There was a problem hiding this comment.
not really a big fan of using <br> to align elements
There was a problem hiding this comment.
me neither !!
Fixed !
aleeks
added
the
Waiting for author
fatmaBouchekoua
force-pushed
the
BOOM-992
branch
from
04b2eab
to
9bca5d0
Compare
FO: Add margin to customization message
maximebiloe
force-pushed
the
BOOM-992
branch
from
9bca5d0
to
ef6781a
Compare
maximebiloe
removed
the
Waiting for author
maximebiloe
approved these changes
Feb 10, 2017
|
Thank you @fatmaBouchekoua |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.