Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear cache on url rewriting settings modification #6988

Merged
merged 1 commit into from Dec 6, 2016
Merged

Clear cache on url rewriting settings modification #6988

merged 1 commit into from Dec 6, 2016

Conversation

antoin-m
Copy link
Contributor

Questions Answers
Branch? develop
Description? The cache should be cleared when enabling/disabling friendly URL rewriting
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1825

How to test?

  • FO: Go on the front page (in order to cache the menu)
  • BO: Disable friendly URLs (Shop parameters => Traffic)
  • FO: Reload the front page
  • FO: Items of the menu should not 404

@aleeks
Copy link
Contributor

aleeks commented Nov 15, 2016

@antoin-m , please, rebase when #6912 will be merged. Yours PR are goods, so you need to mix them :p

mickaelandrieu
mickaelandrieu reviewed Nov 15, 2016
View reviewed changes
classes/Tools.php
$env = _PS_MODE_DEV_ ? 'dev' : 'prod';
}

$sf2Refresh = new \PrestaShopBundle\Service\Cache\Refresh($env);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is a good idea to do this, wdyt @thierrymarianne ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see in this pull request it is already done in a lot of places. I just DRYed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only recommend to import the class with a use statement instead of using the fully qualified class name.

@basma-yangui-prestashop basma-yangui-prestashop added the QA ✔️ Status: check done, code approved label Nov 16, 2016
@aleeks
Copy link
Contributor

aleeks commented Dec 6, 2016

ping @maximebiloe

@maximebiloe maximebiloe merged commit 5b3b1e5 into PrestaShop:develop Dec 6, 2016
@maximebiloe
Copy link
Contributor

Thank you @antoin-m

@maximebiloe maximebiloe removed their assignment Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thierrymarianne thierrymarianne thierrymarianne left review comments

@mickaelandrieu mickaelandrieu mickaelandrieu left review comments

Assignees
No one assigned
Labels
QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@antoin-m @aleeks @maximebiloe @thierrymarianne @mickaelandrieu @basma-yangui-prestashop