Fixed method Order::isVirtual #7222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maximebiloe
commented
Dec 14, 2016
•
maximebiloe
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | The current method check if the product has a download, with "download_hash" and "display_filename" to be considered as virtual; but not every virtual product has a download file, etc. So, simply check if the "is_virtual" index is set to 1 instead of using ProductDownload::getIdFromIdProduct(). |
| Type? | bug fix |
| Category? | CO |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| How to test? | Create an order with a virtual product with a download and an order with a virtual product without a download, then check with (new Order($id_order))->isVirtual(); |
The current method check if the product has a download, with "download_hash" and "display_filename" to be considered as virtual; but not every virtual product has a download file, etc. So, simply check if the "is_virtual" index is set to 1 instead of using ProductDownload::getIdFromIdProduct(). (cherry picked from commit b2737c2)
|
Cherry-pick of #6819 |
|
Thank you @maximebiloe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.