Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace PCRE e modifier with callback #7351

Merged
merged 1 commit into from Jan 18, 2017
Merged

Replace PCRE e modifier with callback #7351

merged 1 commit into from Jan 18, 2017

Conversation

thierrymarianne
Copy link
Contributor

@thierrymarianne thierrymarianne commented Jan 16, 2017 •
edited

Questions Answers
Branch? 1.7.0.x
Description? Replace use of PCRE e modifier with preg_replace_callback
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-2207
How to test? See forge ticket

@thierrymarianne thierrymarianne mentioned this pull request Jan 16, 2017
Closed
@maximebiloe maximebiloe added this to the 1.7.0.5 milestone Jan 16, 2017
@Shudrum Shudrum assigned Shudrum and unassigned Shudrum Jan 16, 2017
@maximebiloe maximebiloe merged commit ea59592 into PrestaShop:1.7.0.x Jan 18, 2017
@maximebiloe
Copy link
Contributor

Thank you @thierrymarianne

@prestonBot prestonBot mentioned this pull request Jan 25, 2017
Merged
@nsorosac nsorosac mentioned this pull request May 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoin-m antoin-m antoin-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thierrymarianne @maximebiloe @antoin-m @Shudrum