Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out of stock combination hiding #7617

Merged
merged 1 commit into from Mar 6, 2017
Merged

Fix out of stock combination hiding #7617

merged 1 commit into from Mar 6, 2017

Conversation

antoin-m
Copy link
Contributor

Questions Answers
Branch? 1.7.1.x
Description? Redirect automagically to the first available combination when the "Display unavailable product attributes on the product page" os set to false.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-2408
How to test? Take a product with combinations and remove the stock for its default combination. Disable the option Configure > Shop parameters > Product Settings > Product Page > Display unavailable product attributes on the product page and go to the product's page. You should have been redirected to the first combination with stock.

aleeks
aleeks approved these changes Feb 27, 2017
View reviewed changes
Copy link
Contributor

@aleeks aleeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Quetzacoalt91 Quetzacoalt91 added the Waiting for PM Status: action required, waiting for product feedback label Mar 6, 2017
@vincentbz vincentbz removed the Waiting for PM Status: action required, waiting for product feedback label Mar 6, 2017
@vincentbz
Copy link
Contributor

Tested and ok, thanks !

@prestonBot prestonBot added the QA ✔️ Status: check done, code approved label Mar 6, 2017
@Quetzacoalt91 Quetzacoalt91 merged commit 2b4d891 into PrestaShop:1.7.1.x Mar 6, 2017
@Quetzacoalt91
Copy link
Member

Thanks @antoin-m

@prestonBot prestonBot mentioned this pull request Mar 10, 2017
Closed
@aleeks aleeks deleted the fix/empty-combi branch March 13, 2017 09:01
@xBorderie xBorderie modified the milestone: 1.7.1.0 Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleeks aleeks aleeks approved these changes

Assignees
No one assigned
Labels
QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@antoin-m @vincentbz @Quetzacoalt91 @aleeks @xBorderie @prestonBot