New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to webpack 2 #7640
Closed
Closed
Upgrade to webpack 2 #7640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nihco2
commented
Mar 6, 2017
Questions | Answers |
---|---|
Branch? | develop |
Description? | Upgrade assets compilation to webpack 2 |
Type? | improvement |
Category? | BO |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | (optional) |
How to test? | Check if there is something broken on new theme pages |
No BC breaking? Are you sure? |
nihco2
added
the
Waiting for QA
Status: action required, waiting for test feedback
label
Mar 6, 2017
Add public path to webpack file loader rule
Make public path relative
@xBorderie I close this PR, we enclose theses changes in #7631 |
Fine by me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.