Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use trans() instead of undefined l() #7711

Merged
merged 2 commits into from Mar 30, 2017
Merged

Use trans() instead of undefined l() #7711

merged 2 commits into from Mar 30, 2017

Conversation

maximebiloe
Copy link
Contributor

Questions Answers
Branch? 1.7.1.x
Description? Use trans() instead of undefined l() into FrontController to prevent error 500. Even if there is the string freeze, we prefer to have 3 untranslated strings instead of error 500.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-2650
How to test?

@maximebiloe maximebiloe added this to the 1.7.1.1 milestone Mar 28, 2017
@maximebiloe maximebiloe merged commit 8a6718e into PrestaShop:1.7.1.x Mar 30, 2017
@maximebiloe maximebiloe deleted the boom-2650 branch March 30, 2017 16:22
@maximebiloe maximebiloe modified the milestones: 1.7.1.0, 1.7.1.1 Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleeks aleeks aleeks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maximebiloe @aleeks