Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FO: Fix product pagination #8150

Closed
wants to merge 1 commit into from
Closed

FO: Fix product pagination #8150

wants to merge 1 commit into from

Conversation

TechhDan
Copy link
Contributor

Questions Answers
Branch? 1.6.1.x
Description? Product pagination text is broken while blocklayered is enabled.
Type? bug fix
Category? FO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-9197
How to test? Set products per page to 2. Product pagination will show wrong text such as "8 - 7 out of 7".

Fix product pagination
@prestonBot
Copy link
Collaborator

Hi!

These(s) commit(s) name(s) seems to be incomplete or malformed, regarding our guidelines:

`Update blocklayered.js

Fix product pagination` is malformed or incomplete.

A valid commit name can be, for instance:

BO: Shows company in BO search if B2B is enabled

Would you mind to amend your commits' names?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

example

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@TechhDan TechhDan changed the title Fix product pagination FO: Fix product pagination Jul 18, 2017
@xBorderie
Copy link
Contributor

Thank you for this PR!

Could you amend your commit's name to use the guidelines, so that it is taken into account by our changelog tool?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

Thank you!

@TechhDan
Copy link
Contributor Author

Ended up having to submit a new PR couldn't restore my repo.. sorry first time contributing lol
New PR:
#8157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants