Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BO: Fix method overrride with different number of parameters #8324

Closed
wants to merge 1 commit into from
Closed

BO: Fix method overrride with different number of parameters #8324

wants to merge 1 commit into from

Conversation

neoteknic
Copy link
Contributor

Affect PHP 7.2 (crash), don't crash in 7.1but violates LSP and should be fixed.

Questions Answers
Branch? "develop"
Description? Invalid parameter of overrided method (should have the same number of paramters).
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Just run the admin dashboard, affect nothing as the $isNewTheme is not used in the overrided method.

Affect PHP 7.2 (crash), don't crash in 7.1but violates LSP and should be fixed.
@prestonBot
Copy link
Collaborator

Hi!

These(s) commit(s) name(s) seems to be incomplete or malformed, regarding our guidelines:

`BO : Fix method overrride with different number of parameters

Affect PHP 7.2 (crash), don't crash in 7.1but violates LSP and should be fixed.` is malformed or incomplete.

A valid commit name can be, for instance:

BO: Shows company in BO search if B2B is enabled

Would you mind to amend your commits' names?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

example

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@neoteknic neoteknic changed the title BO : Fix method overrride with different number of parameters BO: Fix method overrride with different number of parameters Sep 11, 2017
@Quetzacoalt91
Copy link
Member

Hello @neoteknic,

Thanks for your pull-request.
I started the work on PHP 7.2 in order to fix all the crashed reported by the logs. But as it is not released as stable yet, I haven't merged anything yet. You can find the first changes here: #8246. You will see that other controllers need to be updated as well.

Because your suggested changes are already present in #8246, I have to close this one. Sorry about that. :/

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants