New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product page blocks spacing #8375

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
4 participants
@nihco2
Contributor

nihco2 commented Sep 28, 2017

Questions Answers
Branch? develop
Description? Fix spacings
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? Check with design team

@nihco2 nihco2 requested review from vincentbz and Quetzacoalt91 Sep 28, 2017

@Quetzacoalt91

👌 for me

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 28, 2017

Member

@TristanLDD, I suppose your also review is requested on this one? Or this is only for @vincentbz?

Member

Quetzacoalt91 commented Sep 28, 2017

@TristanLDD, I suppose your also review is requested on this one? Or this is only for @vincentbz?

@TristanLDD

This comment has been minimized.

Show comment
Hide comment
@TristanLDD

TristanLDD Oct 2, 2017

@Quetzacoalt91 I've checked the changes with Nico so it's ok for me !

TristanLDD commented Oct 2, 2017

@Quetzacoalt91 I've checked the changes with Nico so it's ok for me !

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 2, 2017

Member

Perfect, thank you

Member

Quetzacoalt91 commented Oct 2, 2017

Perfect, thank you

@Quetzacoalt91 Quetzacoalt91 merged commit 96c4ea5 into PrestaShop:develop Oct 2, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Oct 2, 2017

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Oct 2, 2017

Contributor

Two tabs were missing : combinations details and quantities.

Contributor

vincentbz commented Oct 2, 2017

Two tabs were missing : combinations details and quantities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment