Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace serialize with json_encode #8786

Merged
merged 1 commit into from Sep 24, 2018
Merged

Replace serialize with json_encode #8786

merged 1 commit into from Sep 24, 2018

Conversation

tomlev
Copy link
Contributor

@tomlev tomlev commented Feb 21, 2018 •
edited by eternoendless

Questions Answers
Branch? 1.6.1.x
Description? Use json_encode() instead of serialize(). Many thanks to ROBIN PERAGLIE from RIPS TECHNOLOGIES
Type? bug fix
Category? BO
BC breaks? no
Deprecations? Does it deprecate an existing feature? yes/no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4804
How to test? test if there is no regression: change of delivery option on cart / filter (especialy date one) still works on AdminOrders

Important guidelines

This change is Reviewable

@tomlev tomlev changed the base branch from develop to 1.6.1.x February 21, 2018 13:31
@eternoendless eternoendless changed the title replace serialize with json_encode Replace serialize with json_encode Feb 21, 2018
@eternoendless eternoendless added this to the 1.6.1.19 milestone Feb 21, 2018
@eternoendless eternoendless added the Waiting for QA Status: action required, waiting for test feedback label Feb 21, 2018
@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 12, 2018
@eternoendless eternoendless modified the milestones: 1.6.1.19, 1.6.1.20 May 24, 2018
@eternoendless eternoendless modified the milestones: 1.6.1.20, 1.6.1.21 Jun 27, 2018
@eternoendless
Copy link
Member

Thank you @tomlev

@eternoendless eternoendless merged commit fe22b47 into PrestaShop:1.6.1.x Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternoendless eternoendless eternoendless approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.6.1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomlev @eternoendless @mickaelandrieu @marionf