New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace serialize with json_encode #8786

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
4 participants
@tomlev
Member

tomlev commented Feb 21, 2018

Questions Answers
Branch? 1.6.1.x
Description? Use json_encode() instead of serialize(). Many thanks to ROBIN PERAGLIE from RIPS TECHNOLOGIES
Type? bug fix
Category? BO
BC breaks? no
Deprecations? Does it deprecate an existing feature? yes/no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4804
How to test? test if there is no regression: change of delivery option on cart / filter (especialy date one) still works on AdminOrders

Important guidelines


This change is Reviewable

@tomlev tomlev changed the base branch from develop to 1.6.1.x Feb 21, 2018

@eternoendless eternoendless changed the title from replace serialize with json_encode to Replace serialize with json_encode Feb 21, 2018

@eternoendless eternoendless added this to the 1.6.1.19 milestone Feb 21, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Sep 24, 2018

Thank you @tomlev

@eternoendless eternoendless merged commit fe22b47 into PrestaShop:1.6.1.x Sep 24, 2018

1 check failed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment