Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize reserved product quantity update #8790

Merged
merged 5 commits into from Mar 27, 2018
Merged

Optimize reserved product quantity update #8790

merged 5 commits into from Mar 27, 2018

Conversation

jocel1
Copy link
Contributor

@jocel1 jocel1 commented Feb 22, 2018 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Optimize the query updating reserved product quantity
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4843
How to test? Access Catalog>Stock with a lot of historyOrders

This change is Reviewable

@jocel1 jocel1 self-assigned this Feb 22, 2018
@jocel1 jocel1 added this to the 1.7.3.1 milestone Feb 22, 2018
Quetzacoalt91
Quetzacoalt91 previously requested changes Feb 22, 2018
View reviewed changes
install-dev/upgrade/sql/1.7.3.1.sql Outdated
SET SESSION sql_mode = '';
SET NAMES 'utf8';

ALTER TABLE `PREFIX_order_detail` DROP KEY product_id, ADD KEY product_id (product_id, product_attribute_id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're on the develop branch, this should be in the file 1.7.4.0.sql

@jocel1 jocel1 modified the milestones: 1.7.3.1, 1.7.4.0 Feb 22, 2018
@LittleBigDev
Copy link
Contributor

:lgtm:

Reviewed 3 of 5 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

LittleBigDev
LittleBigDev previously approved these changes Feb 22, 2018
View reviewed changes
Copy link
Contributor

@LittleBigDev LittleBigDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jocel1

@LittleBigDev LittleBigDev added Waiting for QA Status: action required, waiting for test feedback 1.7.x Branch labels Feb 22, 2018
@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 26, 2018
@mickaelandrieu
Copy link
Contributor

Thanks @jocel1 !

@mickaelandrieu mickaelandrieu merged commit 0024295 into PrestaShop:develop Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickaelandrieu mickaelandrieu mickaelandrieu approved these changes

@LittleBigDev LittleBigDev LittleBigDev left review comments

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 left review comments

@eternoendless eternoendless Awaiting requested review from eternoendless

Assignees

@jocel1 jocel1

Labels
1.7.x Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jocel1 @LittleBigDev @mickaelandrieu @Quetzacoalt91 @rblaurin @marionf