Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loyalty display #8791

Closed
wants to merge 3 commits into from
Closed

Fix loyalty display #8791

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 22, 2018

Questions Answers
Branch? 1.6.1.X
Description? parseInt return an integer
Type? bug fix
Category? FO
BC breaks? I dont kown
Deprecations? Does it deprecate an existing feature? yes/no
How to test? Active no loyality point on discounted product

This change is Reviewable

})
updateLoyaltyView(parseInt($('#our_price_display').text()));
updateLoyaltyView(priceWithDiscountsDisplay);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a global variable? By only seeing this piece of code, and without comment, we could think it will be undefined.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes u can check :

http://www.chafoins.com/prestashop/chemisiers/2-chemisier.html#/11-couleur-noir/2-taille-m

Open the console i add a console.log

Noir M is a combination with discount

@ghost
Copy link
Author

ghost commented Aug 29, 2019

Closed because 1.6 support ended

@ghost ghost closed this Aug 29, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants