Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on getting correct meta information in MultiShop context #8880

Closed
wants to merge 1 commit into from

Conversation

AntoInta
Copy link
Contributor

@AntoInta AntoInta commented Mar 26, 2018

The fix let to retrieve the correct information of the controllers in a multishop context.
Before this fix, always the default shop information has retrieved.

Questions Answers
Branch? develop
Description? Removed the cast of $id_shop to int, that's because the method creating the query to retrieve meta_lang information get the correct contextual shop ID only if $id_shop is null, not zero (I really don't know if is better to modify Dispatcher (this PR) or the Shop method "addSqlRestrictionOnLang" )
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? You must have a multishop context, go to BO in Traffic&SEO section, then for the first shop modify information of a page (i.e. url_rewrite), for the other shop modify the same page with different information (i.e. different url_rewrite). In FO, in the second Shop you will get error 404 if the page has different url_rewrite, or you can check other meta info in page related always to the first Shop.

Important guidelines


This change is Reviewable

The fix let to retrieve the correct information of the controllers in a multishop context.
Before this fix, always the default shop information has retrieved.
@mickaelandrieu mickaelandrieu added the 1.7.x Branch label Mar 27, 2018
Copy link
Contributor

@alegout alegout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AntoInta !

@alegout alegout added Code reviewed Waiting for QA Status: action required, waiting for test feedback labels Mar 29, 2018
@marionf
Copy link
Contributor

marionf commented Mar 29, 2018

Hello @AntoInta

I can't reproduce the issue you describe.
I defined 2 different rewrite URL for the contact us page for each store, but I have no issue in FO and can see the good meta title

Shop 1.7.3.0
capture du 2018-03-29 14-35-45
capture du 2018-03-29 14-36-18

Shop2
capture du 2018-03-29 14-36-56
capture du 2018-03-29 14-37-25

@marionf marionf added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 29, 2018
@mickaelandrieu mickaelandrieu added the Bug Type: Bug label Apr 3, 2018
@mickaelandrieu mickaelandrieu added develop Branch and removed 1.7.x Branch labels May 7, 2018
@marionf
Copy link
Contributor

marionf commented Oct 22, 2019

Hello @AntoInta

Since we can't reproduce the issue described in this PR and we had no news, I close the PR
Feel free to open an issue with the steps to reproduce the issue if you still have it on the last version

@marionf marionf closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug develop Branch Waiting for author Status: action required, waiting for author feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants