[+] FO : Rich Snippets support, HTML5 markup, and ARIA roles #89
Conversation
dunglas
commented
Dec 12, 2012
dunglas
commented
- Adds some HTML5 semantic tags and Modernizr
- Enables Google Rich Snippets support using Schema.org microdata
- Adds main, navigation, search, complementary, contentinfo and banner ARIA roles
|
Added complementary and contentinfo ARIA roles. |
|
You can also remove "type" from javascript foreach and css |
|
@kpodemski done. |
|
An improvement will be to replace div of blocks in aside by article tags. |
|
Great, but now... maybe we should implement modernizr or simplier version of enabling HTML5 tags in IE? At this moment we have html5 tags but that's not work in crazIEst browser |
|
Maybe html5shiv instead of the full Modernizr will do the job? |
|
yep, modernizr is too big |
|
Just htmlshiv and css classes would be great : http://modernizr.com/download/#-shiv-cssclasses ;) |
|
@gbelorgey done |
|
What about this PR? |
|
It's annoying that such positive changes are not taken into account! |
|
@kpodemski I agree. I've released a standalone theme including those changes: http://dunglas.fr/2013/01/un-theme-prestashop-html5-optimise-pour-le-referencement-avec-rich-snippets/ |
|
Is there any plan to merge this PR? Anyone from the Prestashop team here? |
|
Hi there, Yes, that's a good question... |
|
@PrestaShop anyone?! |
ghost
assigned
|
@PrestaShop @rGaillard @vAugagneur @DamienMetzger @jeromenadaud can you merge this PR? Opened 9 months ago... |
|
Hello @dunglas I'm sorry that we didn't come back at you earlier. We are really interest in rich snippets - the default theme for the 1.6.0 version will include (some of) them. Your pull request is really great and it would be awesome if you could make this PR for the 1.6.0 theme (available in a few weeks). I personally guarantee that this PR would not stay open as long as this one. Just one thing, please do not modify the charset :) Thanks a lot for your involvement. |
|
The charset is still UTF-8 but the new HTML5 syntax for meta is used. |
|
prestashop 1.6 is going to be rich 💎 Than I won't have to edit after every upgrade |
Use Prestashop requirements in Upgrade check list
