Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajax will never die #9039

Merged
merged 3 commits into from May 25, 2018
Merged

Ajax will never die #9039

merged 3 commits into from May 25, 2018

Conversation

jocel1
Copy link
Contributor

@jocel1 jocel1 commented May 7, 2018 •
edited

Questions Answers
Branch? develop
Description? ajax calls ajaxDie which fails to properly call the actionDispatcherAfter hook (whereas actionDispatcher & actionDispatcherBefore are properly called). I replace it by ajaxRender which will never die()
Type? bug fix
Category? CO
BC breaks? no, the old ajaxDie function is still here for module which are using it
Deprecations? no
How to test? Check the ajax calls are still working properly

This change is Reviewable

@prestonBot prestonBot added the develop Branch label May 7, 2018
@jocel1 jocel1 self-assigned this May 7, 2018
@mickaelandrieu mickaelandrieu removed their request for review May 7, 2018 20:13
@mickaelandrieu mickaelandrieu added the Bug Type: Bug label May 7, 2018
@jocel1
Copy link
Contributor Author

jocel1 commented May 24, 2018

@marionf This one is in production on a real big shop for a few weeks now without any known issues, do we still need QA approval?

@marionf
Copy link
Contributor

marionf commented May 25, 2018

@jocel1 I don't think so :)

@jocel1 jocel1 merged commit 75d6836 into PrestaShop:develop May 25, 2018
@eternoendless eternoendless added this to the 1.7.5.0 milestone May 25, 2018
eternoendless
eternoendless reviewed May 25, 2018
View reviewed changes
controllers/front/ChangeCurrencyController.php
}
$this->ajaxDie('0');
$this->ajaxRender('0');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will output '10'

@eternoendless eternoendless changed the title ajax will never die Ajax will never die May 25, 2018
@jocel1 jocel1 deleted the ajax-never-dies branch May 25, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternoendless eternoendless eternoendless left review comments

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees

@jocel1 jocel1

Labels
Bug Type: Bug develop Branch
Projects
None yet
Milestone
1.7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jocel1 @marionf @eternoendless @Quetzacoalt91 @mickaelandrieu @prestonBot