Deprecate polyfill function array_replace() #9056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove polyfill function Tools::array_replace() for PHP versions <= 5.2 since PHP 5.2 is no longer supported (according to https://www.prestashop.com/en/system-requirements)
classes/Tools.php
Outdated
| * | ||
| * @return array|mixed|null | ||
| */ | ||
| public static function array_replace() |
There was a problem hiding this comment.
we can deprecate it but not remove it: think about all modules that may use it 👍
There was a problem hiding this comment.
as you can see, we use it in core (but you remove this call in the next contribution) but we can't update every modules that comes from contributors.
There was a problem hiding this comment.
@mickaelandrieu Ok, made another commit, thank you! Just for my information: do deprecated functions stay in the codebase forever? I saw Symfony for example removes deprecated code (on major versions?)
mickaelandrieu
added
Improvement
classes/Tools.php
Outdated
| @@ -779,14 +779,17 @@ public static function convertPrice($price, $currency = null, $to_currency = tru | |||
|
|
|||
| return $price; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I have the feeling you have introduced some extra spaces here, isn't it?
| */ | ||
| public static function array_replace() | ||
| { | ||
| Tools::displayAsDeprecated('Use PHP\'s array_replace() instead'); |
mickaelandrieu
changed the title
mickaelandrieu
removed
the
Waiting for author
mickaelandrieu
approved these changes
May 16, 2018
|
Thanks @michaelKaefer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove polyfill function Tools::array_replace() for PHP versions <= 5.2 since PHP 5.2 is no longer supported (according to https://www.prestashop.com/en/system-requirements)
This change is