Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons in product page #9127

Merged
merged 1 commit into from Jun 5, 2018
Merged

Buttons in product page #9127

merged 1 commit into from Jun 5, 2018

Conversation

fouratachour
Copy link
Contributor

@fouratachour fouratachour commented May 25, 2018 •
edited

Questions Answers
Branch? develop
Description? This PR allows to check all buttons in create product page
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? Run the script path=full/02_product/10_check_product_page_buttons.js npm run specific-test -- --URL=BackOfficeURL

This change is Reviewable

@prestonBot prestonBot added the develop Branch label May 25, 2018
PierreRambaud
PierreRambaud previously approved these changes May 25, 2018
View reviewed changes
@mickaelandrieu mickaelandrieu added the TE Category: Tests label May 28, 2018
@fatmaBouchekoua fatmaBouchekoua mentioned this pull request May 30, 2018
Merged
@marionf
Copy link
Contributor

marionf commented May 30, 2018

Hello @fouratachour
After clicking on the delete button in the bottom of the product page and on "Yes" in the modal, we need to check on the catalog page if the product isn't here anymore (in addition to the presence of the message "Product successfully deleted.")
We need also to click on "No" in the modal after clicking on the delete button & check if we are still on the product page with the name of the product

I have updated the scenario "Buttons in footer product page" on test link

@marionf marionf added the Waiting for author Status: action required, waiting for author feedback label May 30, 2018
@fouratachour
Copy link
Contributor Author

Hello @marionf
Done, Script updated !

@marionf
Copy link
Contributor

marionf commented May 31, 2018

Thank you @fouratachour :)

@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for author Status: action required, waiting for author feedback labels May 31, 2018
@mickaelandrieu mickaelandrieu merged commit a26d35a into PrestaShop:develop Jun 5, 2018
@mickaelandrieu
Copy link
Contributor

Thanks everyone!

@eternoendless eternoendless added this to the 1.7.5.0 milestone Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickaelandrieu mickaelandrieu mickaelandrieu approved these changes

@PierreRambaud PierreRambaud PierreRambaud left review comments

Assignees
No one assigned
Labels
develop Branch QA ✔️ Status: check done, code approved TE Category: Tests
Projects
None yet
Milestone
1.7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fouratachour @marionf @mickaelandrieu @PierreRambaud @eternoendless @prestonBot