New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons in product page #9127

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
6 participants
@fouratachour
Contributor

fouratachour commented May 25, 2018

Questions Answers
Branch? develop
Description? This PR allows to check all buttons in create product page
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? Run the script path=full/02_product/10_check_product_page_buttons.js npm run specific-test -- --URL=BackOfficeURL

This change is Reviewable

@prestonBot prestonBot added the develop label May 25, 2018

@marionf

This comment has been minimized.

Contributor

marionf commented May 30, 2018

Hello @fouratachour
After clicking on the delete button in the bottom of the product page and on "Yes" in the modal, we need to check on the catalog page if the product isn't here anymore (in addition to the presence of the message "Product successfully deleted.")
We need also to click on "No" in the modal after clicking on the delete button & check if we are still on the product page with the name of the product

I have updated the scenario "Buttons in footer product page" on test link

@fouratachour

This comment has been minimized.

Contributor

fouratachour commented May 31, 2018

Hello @marionf
Done, Script updated !

@marionf

This comment has been minimized.

Contributor

marionf commented May 31, 2018

Thank you @fouratachour :)

@mickaelandrieu mickaelandrieu merged commit a26d35a into PrestaShop:develop Jun 5, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 5, 2018

Thanks everyone!

@eternoendless eternoendless added this to the 1.7.5.0 milestone Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment