Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated contributor list #9155

Merged
merged 1 commit into from May 31, 2018
Merged

Updated contributor list #9155

merged 1 commit into from May 31, 2018

Conversation

michaelKaefer
Copy link
Contributor

@michaelKaefer michaelKaefer commented May 31, 2018

Questions Answers
Branch? develop
Description? Add myself to contributors list
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? -

This change is Reviewable

@prestonBot
Copy link
Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The type should be one of: new feature, improvement, bug fix, refacto or critical.
  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@prestonBot prestonBot added the develop Branch label May 31, 2018
@mickaelandrieu mickaelandrieu added the Improvement Type: Improvement label May 31, 2018
@mickaelandrieu
Copy link
Contributor

So, I guess we're good and we don't need to add @author anymore, am I right?

@mickaelandrieu mickaelandrieu merged commit a8ddc1d into PrestaShop:develop May 31, 2018
@mickaelandrieu
Copy link
Contributor

Thanks!

@Quetzacoalt91
Copy link
Member

For your information, this list is also updated on each release. :)

@eternoendless eternoendless added this to the 1.7.5.0 milestone Jun 6, 2018
@eternoendless
Copy link
Member

Guys, please don't merge this kinds of PRs again. He would have been added to the contributors list as part of our usual release process.

Our tool makes a diff out of the current contributors list and the generated one to pull out the list of first time contributors. Now I will have to remember to add him to the list manually...

@eternoendless eternoendless changed the title Added myself Updated contributor list Aug 27, 2018
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants