Unable to copy theme translations #9267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While copying theme translations prestashop shows message about non existing themes. It tries to match directory to a theme name. I dunno if its bug on form side, and $from_theme and $to_theme should be directories or prestashop should match names with names rather than directories. This helped to copy most of the translations. but I still received an error message "Unable to copy "/var/www/html/lagaminai/themes/classic/lang/lt.php" to "/var/www/html/lagaminai/themes/***/lang/lt.php""
|
Hello @vytsci! This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community! |
mickaelandrieu
approved these changes
Jul 9, 2018
mickaelandrieu
added
the
Waiting for QA
|
Hello @vytsci Thanks for your contribution :)
|
marionf
added
Waiting for author
|
Yes because I didnt fix those. I just changed the lines so PS can see themes as installed. I did not test nor fixed any further errors. |
marionf
added
QA ✔️
|
Thank you @vytsci |
|
Sorry, I dont have enough time for full PR. But this is a start and in some cases you end up with what you needed. This is just a hint for PS team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While copying theme translations prestashop shows message about non existing themes. It tries to match directory to a theme name. I dunno if its bug on form side, and $from_theme and $to_theme should be directories or prestashop should match names with names rather than directories. This helped to copy most of the translations. but I still received an error message "Unable to copy "/var/www/html/lagaminai/themes/classic/lang/lt.php" to "/var/www/html/lagaminai/themes/***/lang/lt.php""
Important guidelines
This change is