New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all translations errors from localization page #9455

Merged
merged 1 commit into from Aug 17, 2018

Conversation

Projects
None yet
5 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Aug 16, 2018

Questions Answers
Branch? develop
Description? I've noticed we have a lot of logs errors in this page, this is because the forms try to translate already translated strings, so he can't find the related translation.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Improve > Translations > Localization page should behave the same, but in debug mode, you should not have so many logs anymore.

Before

before

After

after


This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 17, 2018

@ntiepresta ntiepresta self-assigned this Aug 17, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Aug 17, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Aug 17, 2018

Thank you @mickaelandrieu

@eternoendless eternoendless merged commit 3c58ba0 into PrestaShop:develop Aug 17, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:bugfix/form-translations branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment