Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed all translations errors from localization page #9455

Merged
merged 1 commit into from Aug 17, 2018
Merged

Removed all translations errors from localization page #9455

merged 1 commit into from Aug 17, 2018

Conversation

mickaelandrieu
Copy link
Contributor

@mickaelandrieu mickaelandrieu commented Aug 16, 2018 •
edited

Questions Answers
Branch? develop
Description? I've noticed we have a lot of logs errors in this page, this is because the forms try to translate already translated strings, so he can't find the related translation.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Improve > Translations > Localization page should behave the same, but in debug mode, you should not have so many logs anymore.

Before

before

After

after

This change is Reviewable

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Aug 16, 2018
@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 17, 2018
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Aug 17, 2018
@ntiepresta ntiepresta self-assigned this Aug 17, 2018
@ntiepresta ntiepresta added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Aug 17, 2018
@eternoendless
Copy link
Member

Thank you @mickaelandrieu

@eternoendless eternoendless merged commit 3c58ba0 into PrestaShop:develop Aug 17, 2018
@mickaelandrieu mickaelandrieu deleted the bugfix/form-translations branch August 17, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees

@ntiepresta ntiepresta

Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mickaelandrieu @eternoendless @PierreRambaud @prestonBot @ntiepresta