Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain degraded mode #66

Merged
merged 1 commit into from Sep 1, 2023
Merged

Explain degraded mode #66

merged 1 commit into from Sep 1, 2023

Conversation

matks
Copy link
Contributor

@matks matks commented Sep 1, 2023

Questions Answers
Description? Explain degraded mode in readme
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test?

@matks matks merged commit ee95d78 into PrestaShop:prod Sep 1, 2023
@matks matks deleted the explain-readme-2 branch September 1, 2023 12:28
@nicosomb
Copy link
Contributor

nicosomb commented Sep 1, 2023

Merged without required approvals !? :trollface:

😅

@matks
Copy link
Contributor Author

matks commented Sep 1, 2023

As the CI was completely broken, it was impossible to merge any PR, even the ones that simply added new documentation files.

I realized the work to fix the CI would be quite long, and that until the CI was fixed, no PR could be merged. Not even a PR to explain the project situation or to give directions about how to deal with this.

So I've been tinkering all morning (see #57, #59, #60, #61 ...) to make it somehow works, and yes, I forced the merge without approvals or green CI as it would simply never happen 🤷‍♂️ .

This PR #66 is the last I will do using this method as the explore-and-tinker phase is done:

Sometimes the end justifies the means 😉 .

@nicosomb
Copy link
Contributor

nicosomb commented Sep 1, 2023

My comment was only a little troll / joke, don't worry 😘

@matks
Copy link
Contributor Author

matks commented Sep 1, 2023

I think everyone deserve a transparent explanation 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants