Remove TreeBuilder deprecation #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreRambaud
approved these changes
Mar 14, 2022
|
CI is read because code coverage decreased by 0.3% |
MeKeyCool
approved these changes
Mar 14, 2022
atomiix
force-pushed
the
treebuilder-deprecation
branch
from
0279c5d
to
f920fad
Compare
atomiix
force-pushed
the
treebuilder-deprecation
branch
from
f920fad
to
3504d90
Compare
Progi1984
reviewed
Mar 15, 2022
Progi1984
reviewed
Mar 15, 2022
Progi1984
reviewed
Mar 15, 2022
Co-authored-by: Progi1984 <progi1984@gmail.com>
PierreRambaud
approved these changes
Mar 15, 2022
Progi1984
approved these changes
Mar 16, 2022
|
Thanks @atomiix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TreeBuilder's constructor should be called with the root node name as first argument instead of calling theroot()method later on. To keep backward compatibility, this PR checks that theTreeBuilderclass has a method calledgetRootNodewhich appeared when theroot()method was deprecated, to know how to callTreeBuilder's constructor. This is inspired from #95 (comment) but without using reflection.